Skip to content

Fix test fails #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tapvt wants to merge 4 commits into from
Closed

Fix test fails #1037

tapvt wants to merge 4 commits into from

Conversation

@tapvt
Copy link

@tapvt tapvt commented Feb 17, 2025

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The tests run

Checklist:

  • [x ] My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers

tapvt added 2 commits February 17, 2025 09:32
@tapvt
add missing deps [fzf, vscrui]
b5422d2
@tapvt
refactor: replace console.log with logger in abortStream
3d3d581 
Following logging guidelines to use the logger from utils/logging instead of console.log for better debugging control in test environments.
@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0f12d04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

tapvt added 2 commits February 18, 2025 11:37
@tapvt
refactor: improve error handling for empty conversation history
f877740 
- Initialize empty arrays for modified user content and API conversation history
- Change error throw to debug log when no conversation history exists
@tapvt
fix: use logger.debug instead of console.debug in resumeTaskFromHistory
0f12d04 
Replaces console.debug with logger.debug to prevent 'Cannot log after tests are done' error in Jest tests. This change follows project logging guidelines and ensures proper test lifecycle handling.
@hannesrudolph hannesrudolph moved this to To triage in Roo Code Roadmap Mar 5, 2025
@hannesrudolph hannesrudolph moved this from To triage to PR - Needs Approval in Roo Code Roadmap Mar 6, 2025
@mrubens mrubens moved this from PR [Unverified] to PR [Deferred] in Roo Code Roadmap Mar 10, 2025
@samhvw8 samhvw8 closed this Mar 18, 2025
@github-project-automation github-project-automation bot moved this from PR [Deferred] to Done in Roo Code Roadmap Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrubens mrubens Awaiting requested review from mrubens mrubens will be requested when the pull request is marked ready for review mrubens is a code owner

@cte cte Awaiting requested review from cte cte will be requested when the pull request is marked ready for review cte is a code owner

@jr jr Awaiting requested review from jr jr will be requested when the pull request is marked ready for review jr is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tapvt @samhvw8